From alsa-devel-owner@alsa.jcu.cz  Sun Nov  1 21:01:04 1998
Received: from entry.jcu.cz (IDENT:perex@entry.jcu.cz [160.217.1.111])
	by marvin.jcu.cz (8.9.1a/8.9.1) with SMTP id UAA21091;
	Sun, 1 Nov 1998 20:58:47 +0100
Date: Sun, 1 Nov 1998 20:58:47 +0100 (CET)
From: Jaroslav Kysela <perex@jcu.cz>
To: Ulf Carlsson <ulfc@bun.falkenberg.se>
cc: alsa-devel@alsa.jcu.cz
Subject: Re: ALSA coding style
In-Reply-To: <19981101195525.A3309@bun.falkenberg.se>
Message-ID: <Pine.LNX.3.96.981101204921.12661E-100000@entry.jcu.cz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: alsa-devel@alsa.jcu.cz
Sender: alsa-devel-owner@alsa.jcu.cz
Precedence: list

On Sun, 1 Nov 1998, Ulf Carlsson wrote:

> Hi,
> 
> I have been talking to some people on LinuxNet #linux, and many persons,
> including myself, seem to be annoyed by your coding style.

:-(((((( I'm sorry, but I'm using this my default coding style about five
years :-(((((

> Andrew T. Veliath had the idea that you're using this coding style to control
> the project. People often use a strange coding style if they don't want anyone
> else to contribute, is this correct? If that's the case, fine with me..

No, I will like see new contributors...

> Alan Cox said that the plans for 2.3.x are to use parts of the ALSA driver in th
> kernel, and he really hopes that they will be ran through indent before they go

I willn't support ALSA driver in kernel before sequencer code will be
done... I expect very much changes which should be done in separate line..

> into the kernel to make them readable. So, the sooner you change it the more
> work you'll save. You can for example by running it through indent (decent
> options can be found in the kernel source, Documentation/CodingStyle) and/or
> change it by hand (after reading Documentation/CodingStyle CAREFULLY). I was
> actually going to write a HAL2 driver for ALSA, but when I looked closer at your
> coding style I gave up (got to bad headaches).
> 
> If you want me and probably others to contribute, please:
> 
> . Break lines your lines, they should fit on a 80 width display
> . Don't try to do more than one thing at one line
> . Use tabs instead of spaces, you can atleast use tabs and configure your editor
>   to 2 spaces tabwidth
> . Please don't use spaces around '->' 

I know about Linux coding style, but it is very very light for me (it
eats too much space). OK. I want write good Linux code and thus I probably
must accept (for me old and strange) coding style... The indent is easy
way and I'll try convert all sources with some corrections next week after
0.2.0pre9 will be released... Please, wait a little bit and I hope that we
will see your ALSA HAL2 driver soon...

							Jaroslav

-----
Jaroslav Kysela <perex@jcu.cz>
Academic Computer Centre, University of South Bohemia
Branisovska 31, C. Budejovice, CZ-370 05 Czech Republic


