From alsa-devel-owner@alsa.jcu.cz  Tue Oct 27 20:41:36 1998
Received: from entry.jcu.cz (IDENT:perex@entry.jcu.cz [160.217.1.111])
	by marvin.jcu.cz (8.9.1a/8.9.1) with SMTP id UAA31216;
	Tue, 27 Oct 1998 20:41:27 +0100
Date: Tue, 27 Oct 1998 20:41:26 +0100 (CET)
From: Jaroslav Kysela <perex@jcu.cz>
To: Fred Floberg <emng@geocities.com>
cc: alsa-devel@jcu.cz
Subject: Re: Ensonic Bug fixed
In-Reply-To: <Pine.LNX.3.95.981027145529.7162A-100000@cyphyn.219.org>
Message-ID: <Pine.LNX.3.96.981027203557.28496E-100000@entry.jcu.cz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: alsa-devel@alsa.jcu.cz
Sender: alsa-devel-owner@alsa.jcu.cz
Precedence: list

On Tue, 27 Oct 1998, Fred Floberg wrote:

> I notice though, that what I think might have been an omission hasn't
> been addressed. So I'll bring it up.
> 
> In line 290 of alsa-driver/lowlevel/pci/es1370.c there is the function
> 
> snd_ensoniq_playback1_ioctl(...)
> 
> This function doesn't seem to be able to return successfully (with a value
> of 0) as is the case with the next function
> 
> snd_ensoniq_playback2_ioctl(...)
> 
> Shouldn't there be a "return 0;" after the else clause like in
> snd_ensoniq_playback2_ioctl(...)?

Yes, return is missing, but this error doesn't affect other middle level
code - it simply ignores return value. Nothing will be changed with
functionality of driver. Anyway - thank you for notice - fixed on CVS.

> Also (and possibly related), when running my full-duplex test prog
> I get the following... Notice the Rates for Playback and Record...
> When the sample rate of 48000Hz is requested 48000Hz is what's
> gotten. I haven't tried with other sample rates yet.
> Is this a limitation of the AudioPCI card (SRC black magic)?

Yes, look to snd_es1371_*_rate functions....

							Jaroslav

-----
Jaroslav Kysela <perex@jcu.cz>
Academic Computer Centre, University of South Bohemia
Branisovska 31, C. Budejovice, CZ-370 05 Czech Republic


