From alsa-devel-owner@alsa.jcu.cz  Tue Oct 27 20:18:48 1998
Received: from cyphyn.219.org (nwhn-sh1-port36.snet.net [204.60.13.36])
	by marvin.jcu.cz (8.9.1a/8.9.1) with ESMTP id UAA29478
	for <alsa-devel@jcu.cz>; Tue, 27 Oct 1998 20:16:45 +0100
Received: from localhost (emng@localhost)
          by cyphyn.219.org (8.8.4/8.8.4) with SMTP
	  id PAA07269 for <alsa-devel@jcu.cz>; Tue, 27 Oct 1998 15:20:40 -0500
Date: Tue, 27 Oct 1998 15:20:40 -0500 (EST)
From: Fred Floberg <emng@geocities.com>
To: alsa-devel@jcu.cz
Subject: Re: Ensonic Bug fixed
In-Reply-To: <199810271849.NAA06233@cyphyn.219.org>
Message-ID: <Pine.LNX.3.95.981027145529.7162A-100000@cyphyn.219.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: alsa-devel@alsa.jcu.cz
Sender: alsa-devel-owner@alsa.jcu.cz
Precedence: list



On Tue, 27 Oct 1998 lansdoct@screech.cs.alfred.edu wrote:

> Hi all,
> 	The bug that was causing 2 error messages (codec read error 0x14
> [0xffffffff]) has been fixed in CVS.
> 	-Chris
> 
Wonderful! I've updated from the CVS tree and will be testing it.
(And Chris, thanks for your response to my question about int's vs.
long's)

I notice though, that what I think might have been an omission hasn't
been addressed. So I'll bring it up.

In line 290 of alsa-driver/lowlevel/pci/es1370.c there is the function

snd_ensoniq_playback1_ioctl(...)

This function doesn't seem to be able to return successfully (with a value
of 0) as is the case with the next function

snd_ensoniq_playback2_ioctl(...)

Shouldn't there be a "return 0;" after the else clause like in
snd_ensoniq_playback2_ioctl(...)?

Also (and possibly related), when running my full-duplex test prog
I get the following... Notice the Rates for Playback and Record...
When the sample rate of 48000Hz is requested 48000Hz is what's
gotten. I haven't tried with other sample rates yet.
Is this a limitation of the AudioPCI card (SRC black magic)?

# cat /proc/asound/0/pcm0
ES1371 DAC2/ADC

Playback
  Mode           : native
  Format         : Signed 16-bit Little Endian
  Rate           : 44099Hz [requested 44100Hz]
  Channels       : 2
  Buffer size    : 131072
  Buffer used    : 131072
  Fragments      : 2
  Fragment size  : 65536
  Fragments room : 1
  Fragments max  : 1
  Underruns      : 0
  Total underruns: 2
Record
  Mode           : native
  Format         : Signed 16-bit Little Endian
  Rate           : 44101Hz [requested 44100Hz]
  Channels       : 2
  Buffer size    : 131072
  Buffer used    : 131072
  Fragments      : 2
  Fragment size  : 65536
  Fragments min  : 1
  Overruns       : 0
  Total overruns : 0



