From alsa-devel-owner@alsa.jcu.cz  Wed Feb 10 11:08:57 1999
Received: from entry.jcu.cz (IDENT:perex@entry.jcu.cz [160.217.1.111])
	by marvin.jcu.cz (8.9.1a/8.9.1) with SMTP id LAA17648;
	Wed, 10 Feb 1999 11:04:19 +0100
Date: Wed, 10 Feb 1999 11:04:19 +0100 (CET)
From: Jaroslav Kysela <perex@jcu.cz>
To: Steve Ratcliffe <steve@parabola.demon.co.uk>
cc: alsa-devel@alsa.jcu.cz
Subject: Re: Client/port callbacks
In-Reply-To: <199902092313.XAA05236@ariel.sr.home>
Message-ID: <Pine.LNX.3.96.990210105949.3166B-100000@entry.jcu.cz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: alsa-devel@alsa.jcu.cz
Sender: alsa-devel-owner@alsa.jcu.cz
Precedence: list

On Tue, 9 Feb 1999, Steve Ratcliffe wrote:

> Jaroslav, Frank,
> 
> I have a question about the way snd_seq_client_callback_t is used.
> 
> There is one input routine per client along with a private data field.
> Each port has its own private data.
> 
> Typically this input routine wants to use the private data belonging
> to the destination port.  For example see event_input() in seq_midi.c.
> This means that the client private data must also include pointers to
> all the port private data structures.
> 
> It seems more natural for the sequencer core to pass the relevant port
> private data to the input routine, and perhaps it would be even better
> to also move the input routine from the client callbacks into the port
> callbacks.
> 
> What do you think?

I agree. The ports are independend. If you would do these changes, I'll
include them to driver sources.

							Jaroslav

-----
Jaroslav Kysela <perex@jcu.cz>
Academic Computer Centre, University of South Bohemia
Branisovska 31, C. Budejovice, CZ-370 05 Czech Republic


